lkml.org 
[lkml]   [2015]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] net: Linn Ethernet Packet Sniffer driver

    On 23/01/15 10:51, Mark Rutland wrote:
    >
    > diff --git a/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt b/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt
    > new file mode 100644
    > index 0000000..6b6e105
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/net/linn-ether-packet-sniffer.txt
    > @@ -0,0 +1,27 @@
    > +* Linn Products Ethernet Packet Sniffer
    > +
    > +Required properties:
    > +- compatible : must be "linn,eth-sniffer"
    > +- reg : physical addresses and sizes of registers. Must contain 3 entries:
    > + first entry: registers memory space
    > + second entry: TX command memory
    > + third entry: RX command memory
    > Just to check: are those memories are part of the packet sniffer device,
    > or are carveouts from other memory?
    Yes, the 3 memory areas are part of the packet sniffer module.
    >> +- fifo-block-words : number of words in one data FIFO entry
    >> +
    >> +Example:
    >> +
    >> +sniffer@1814a000 {
    >> + compatible = "linn,eth-sniffer";
    >> + reg = <0x1814a000 0x100>, <0x1814a400 0x400>, <0x1814a800 0x400>;
    >> + reg-names = "regs", "tx-ram", "rx-ram";
    >> + interrupts = <GIC_SHARED 58 IRQ_TYPE_LEVEL_HIGH>;
    >> + interrupt-names = "eth-sniffer-irq";
    >> + clocks = <&system_clk>;
    >> + clock-names = "sys";
    >> + fifo-block-words = <4>;
    >> + };
    > Surely the relationship between the sniffer, MAC, and PHY should be
    > described, so we know which interface the sniffer is related to?
    >
    The packet sniffer sits between the MAC and the PHY and monitors TX or RX
    packets, or both. Will add a description in the binding doc.

    Your other suggestions too, will be incorporated in the next version of
    the patch set.

    Thank you,
    Stathis



    \
     
     \ /
      Last update: 2015-01-26 11:21    [W:4.755 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site