lkml.org 
[lkml]   [2015]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] spmi: pmic_arb: add support for hw version 2
Hi Gilad,

<snip>

>> /* Interrupt Controller */
>> #define SPMI_PIC_OWNER_ACC_STATUS(M, N) (0x0000 + ((32 * (M)) + (4 * (N))))
>
> It looks like these macros would change too, but nothing has been done
> here. Interrupts haven't been tested?

Stephen is right, the irq related operations are not used in irq_chip
methods. Do you plan to add it in next version?

<snip>

>> +/**
>> + * pmic_arb_ver: version dependent functionality and values.
>> + *
>> + * @non_data_cmd: on v1 issues an spmi non-data command.
>> + * on v2 no HW support, returns -EOPNOTSUPP.
>> + * @offset: on v1 offset of per-ee channel.
>> + * on v2 offset of per-ee and per-ppid channel.
>> + * @fmt_cmd: formats a GENI/SPMI command.
>> + * @owner_acc_status: on v1 offset of PMIC_ARB_SPMI_PIC_OWNERm_ACC_STATUSn
>> + * on v2 offset of SPMI_PIC_OWNERm_ACC_STATUSn.
>> + * @acc_enable: on v1 offset of PMIC_ARB_SPMI_PIC_ACC_ENABLEn
>> + * on v2 offset of SPMI_PIC_ACC_ENABLEn.
>> + * @irq_status: on v1 offset of PMIC_ARB_SPMI_PIC_IRQ_STATUSn
>> + * on v2 offset of SPMI_PIC_IRQ_STATUSn.
>> + * @irq_clear: on v1 offset of PMIC_ARB_SPMI_PIC_IRQ_CLEARn
>> + * on v2 offset of SPMI_PIC_IRQ_CLEARn.
>> + * @geni_ctrl: PMIC_ARB_GENI_CTRL offset.
>> + * @geni_status: PMIC_ARB_GENI_STATUS offset.
>> + * @protocol_irq_status: PMIC_ARB_PROTOCOL_IRQ_STATUS offset.
>> + */

<snip>

--
regards,
Stan


\
 
 \ /
  Last update: 2015-01-24 14:01    [W:0.103 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site