Messages in this thread | | | Date | Sat, 24 Jan 2015 12:48:51 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH v2 RESEND 2/8] irqchip: Supply new driver for STi based devices |
| |
On Fri, 23 Jan 2015, Lee Jones wrote: > On Fri, 23 Jan 2015, Thomas Gleixner wrote: > > The only technical comment I have is: shouldn't all the stuff except > > the resume function be marked __init or is any of this required post > > init? > > It's not common to mark functions invoked at and affter *_probe() as > __init. At least, not as far as I'm aware.
Right, if the probe stuff is supposed to be functional post init, then we of course need to keep it around. But I guess we have no mechanism to distinguish the 'boot only' and 'keep post init' case. Might be worthwhile to investigate.
Thanks,
tglx
| |