Messages in this thread | | | From | Rasmus Villemoes <> | Subject | Re: [PATCH] ethernet: fm10k: Actually drop 4 bits | Date | Sat, 24 Jan 2015 01:50:06 +0100 |
| |
On Sat, Jan 24 2015, "Vick, Matthew" <matthew.vick@intel.com> wrote:
> Good catch! I noticed this too and was getting a patch together to address > this. > > The difference is that I was planning on not silently accepting an invalid > VLAN ID to begin with and returning FM10K_ERR_PARAM if the VLAN was > invalid, which I think is a better approach for this situation. If it's > alright with you, I'll generate the patch shortly and credit you via your > Reported-by.
Sure, do what you think is best.
Rasmus
| |