Messages in this thread | | | Date | Fri, 23 Jan 2015 08:00:20 -0700 | From | Shuah Khan <> | Subject | Re: [PATCH v4] media: au0828 - convert to use videobuf2 |
| |
On 01/23/2015 02:50 AM, Hans Verkuil wrote: > Hi Shuah, > > On 01/23/2015 12:42 AM, Shuah Khan wrote: >> Convert au0828 to use videobuf2. Tested with NTSC. >> Tested video and vbi devices with xawtv, tvtime, >> and vlc. Ran v4l2-compliance to ensure there are >> no regressions. video now has no failures and vbi >> has 3 fewer failures. >> >> video before: >> test VIDIOC_G_FMT: FAIL 3 failures >> Total: 72, Succeeded: 69, Failed: 3, Warnings: 0 >> >> Video after: >> Total: 72, Succeeded: 72, Failed: 0, Warnings: 18 >> >> vbi before: >> test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: FAIL >> test VIDIOC_EXPBUF: FAIL >> test USERPTR: FAIL >> Total: 72, Succeeded: 66, Failed: 6, Warnings: 0 >> >> vbi after: >> test VIDIOC_QUERYCAP: FAIL >> test MMAP: FAIL >> Total: 78, Succeeded: 75, Failed: 3, Warnings: 0 > > There shouldn't be any fails for VBI. That really needs to be fixed. > Esp. the QUERYCAP fail should be easy to fix. > > BTW, can you paste the full v4l2-compliance output next time? That's > more informative than just these summaries. >
I will re-run the tests and fix it and resend the patch. I think I was seeing querycap compliance failure when run with -V0 option and not when I run it without. I can attach the full log.
thanks, -- Shuah
thanks, -- Shuah
-- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978
| |