Messages in this thread | | | Date | Thu, 22 Jan 2015 20:19:37 -0500 | Subject | Re: [PATCH 8/8] msm: scm: Move the scm driver to drivers/soc/qcom | From | Rob Clark <> |
| |
On Wed, Jan 21, 2015 at 8:13 PM, Olof Johansson <olof@lixom.net> wrote: > I just saw this in the pull request from Kumar, so this is a bit late > w.r.t. to the patch, but so was his merging of the code. :) > > > > On Mon, Aug 4, 2014 at 6:31 PM, Stephen Boyd <sboyd@codeaurora.org> wrote: >> Architectural changes in the ARM Linux kernel tree mandate >> the eventual removal of the mach-* directories. Move the >> scm driver to drivers/soc/qcom and the scm header to >> include/soc/qcom to support that removal. > > The idea is not blindly move one dumping ground to a new place. > > I see only two exported functions from scm.c: > > scm_get_version: This is not used anywhere in the kernel and can just be removed > scm_call: This is used by scm-boot, and would be better to translate > over to firmware_ops in the first place. > > > So, can you please rework this with the above in mind instead of just > moving the files over? Thanks! >
jfyi, we have some pending drm/msm patches blocked on this move
(not trying to comment one way or another on whether all or some should be moved.. just pointing out there would be more in-tree users of it if it was moved)
BR, -R
> > -Olof > -- > To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html
| |