Messages in this thread | | | Date | Thu, 22 Jan 2015 16:23:15 +0100 | From | Jiri Olsa <> | Subject | Re: [PATCH] perf ui/tui: Show fatal error message only if exists |
| |
On Fri, Jan 23, 2015 at 12:08:34AM +0900, Namhyung Kim wrote:
SNIP
> > > "Press any key...", 0); > > > > looks like we display ui_helpline__last_msg also in ui/browsers/annotate.c > > Right, I also saw it. > > > > > do we want to have some common function that unsets tui_helpline__set > > so we're sure we dont get the message twice? > > I doubt that it's really needed.. The annotation code does not > propagate an error so the wait_for_ok arg in ui__exit() will be always > false. In addition, I think it's better to use ui__error() or > ui__warning() directly at the point when something bad happened and we > need to inform user.
ok..
Acked-by: Jiri Olsa <jolsa@kernel.org>
jirka
| |