lkml.org 
[lkml]   [2015]   [Jan]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] firewire: ohci: Remove unused function
On Jan 02 Rickard Strandqvist wrote:
> Remove the function ar_prev_buffer_index() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>

Committed to linux1394.git, thanks. (The function was used in an earlier
version of patch "firewire: ohci: AR rewrite" which later became commit
7a39d8b82165. In a revision of the patch, the use but not the definition
of this function was removed.)

> ---
> drivers/firewire/ohci.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/firewire/ohci.c b/drivers/firewire/ohci.c
> index a66a321..9662daa 100644
> --- a/drivers/firewire/ohci.c
> +++ b/drivers/firewire/ohci.c
> @@ -719,11 +719,6 @@ static inline unsigned int ar_next_buffer_index(unsigned int index)
> return (index + 1) % AR_BUFFERS;
> }
>
> -static inline unsigned int ar_prev_buffer_index(unsigned int index)
> -{
> - return (index - 1 + AR_BUFFERS) % AR_BUFFERS;
> -}
> -
> static inline unsigned int ar_first_buffer_index(struct ar_context *ctx)
> {
> return ar_next_buffer_index(ctx->last_buffer_index);

--
Stefan Richter
-=====-===== ---= =-==-
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2015-01-22 11:41    [W:0.056 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site