lkml.org 
[lkml]   [2015]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH v2 3/3] ARM: dts: Add sound nodes for exynos4412-trats2
Hi,
Thanks for your comments.

On Wed, 21 Jan 2015 17:23:21 +0100
Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:

> Hi,
>
> On 19/01/15 10:48, Inha Song wrote:
> > --- a/arch/arm/boot/dts/exynos4412-trats2.dts
> > +++ b/arch/arm/boot/dts/exynos4412-trats2.dts
>
> > + sound {
> > + compatible = "samsung,trats2-audio";
>
> > + assigned-clocks = <&pmu_system_controller 0>;
> > + assigned-clock-parents = <&clock CLK_XUSBXTI>;
>
> How about putting these properties in the pmu_system_controller
> node? After all the mux clock being configured here belongs to
> the PMU subsystem. Wouldn't it work that way ?
OK, I will move assigned clock properties to pmu_system_controller DT node.

Best Regards,
Inha Song.

>
> > + samsung,i2s-controller = <&i2s0>;
> > + samsung,model = "Trats2";
> > + samsung,audio-codec = <&wm1811>;
> > + samsung,audio-routing =
> > + "SPK", "SPKOUTLN",
> > + "SPK", "SPKOUTLP",
> > + "SPK", "SPKOUTRN",
> > + "SPK", "SPKOUTRP";
> > + };
>
> --
> Regards,
> Sylwester
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel


\
 
 \ /
  Last update: 2015-01-22 02:41    [W:1.332 / U:0.400 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site