lkml.org 
[lkml]   [2015]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] blackfin: mach-common: ints-priority: Remove unused function
From
Hi Rickard,

On Sun, Jan 4, 2015 at 1:01 AM, Rickard Strandqvist
<rickard_strandqvist@spectrumdigital.se> wrote:
> Remove the function bfin_sec_resume() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/blackfin/mach-common/ints-priority.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/arch/blackfin/mach-common/ints-priority.c b/arch/blackfin/mach-common/ints-priority.c
> index dd2af74..7236bdf 100644
> --- a/arch/blackfin/mach-common/ints-priority.c
> +++ b/arch/blackfin/mach-common/ints-priority.c
> @@ -429,14 +429,6 @@ static void init_software_driven_irq(void)
> bfin_sec_enable_ssi(37);
> }
>
> -void bfin_sec_resume(void)
> -{
> - bfin_write_SEC_SCI(0, SEC_CCTL, SEC_CCTL_RESET);
> - udelay(100);
> - bfin_write_SEC_GCTL(SEC_GCTL_EN);
> - bfin_write_SEC_SCI(0, SEC_CCTL, SEC_CCTL_EN | SEC_CCTL_NMI_EN);
> -}
> -
> void handle_sec_sfi_fault(uint32_t gstat)
> {
>
> --
> 1.7.10.4
>
Yes, this bfin_sec_resume() should be dropped.

-steven


\
 
 \ /
  Last update: 2015-01-21 08:01    [W:0.070 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site