lkml.org 
[lkml]   [2015]   [Jan]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 2/3] mfd: lubbock_io: add lubbock_io board
> ----- Mail original -----
> De: "Lee Jones" <lee.jones@linaro.org>
First of all, this is my web mail interface, so please be kind with
my mail formatting ...

> Looking at one of the other patches in the series it appears the flag
> you're trying to capture is IORESOURCE_IRQ_LOWEDGE. When I grep for
> where this is being _used_ (think 'consumed, rather than passed. I
> only see a single entry in drivers/pnp/interface.c.
Look at this call chain :
request_irq()
setup_irq()
__setup_irq()
__irq_set_trigger()
pxa_gpio_irq_type() (aka. chip->irq_set_type)
=> hardware register manipulation

Moreover, you should be aware of the bijection existing between :
- IORESOURCE_IRQ_LOWEDGE and IRQF_TRIGGER_RISING
- it's HIGHEDGE twin
- it is noted in : include/linux/interrupt.h

> That's what got me thinking... are you sure you're a) making use of
this flag
Yes, I'm quite sure.

> b) assuming the answer to 'a' is "no"
I won't :)

> I think to set an edge trigger on an IRQ, you should instead do so via
> irq_set_irq_type(), or have a missed a line or two?
__setup_irq(), that's the entry point.

Cheers.

--
Robert


\
 
 \ /
  Last update: 2015-01-21 14:41    [W:0.106 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site