Messages in this thread | | | Date | Wed, 21 Jan 2015 10:43:56 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [RFC Patch 17/19] resources: Move struct resource_list_entry from ACPI into resource core |
| |
On Wed, 21 Jan 2015, Jiang Liu wrote: > On 2015/1/21 9:10, Rafael J. Wysocki wrote: > >> + > >> +void resource_list_insert(struct list_head *head, > >> + struct resource_list_entry *entry, bool tail) > > > > I would call this resource_list_add() if anything. > > > > Also it may be better to have two helpers, one for "add" and one for "add_tail" > > (and perhaps define them as static inline?). > We can't use inline functions here because that needs pulling list.h > into ioport.h, then causing building issues to header inclusion order.
Create a new header file to avoid the circular dependencies then.
Thanks,
tglx
| |