Messages in this thread | | | Subject | Re: [PATCH] power: max77693: fix simple_return.cocci warnings | From | Krzysztof Kozlowski <> | Date | Wed, 21 Jan 2015 08:59:23 +0100 |
| |
On śro, 2015-01-21 at 12:11 +0800, kbuild test robot wrote: > drivers/power/max77693_charger.c:615:1-4: WARNING: end returns can be simpified > > Simplify a trivial if-return sequence. Possibly combine with a > preceding function call. > Generated by: scripts/coccinelle/misc/simple_return.cocci > > CC: Krzysztof Kozlowski <k.kozlowski@samsung.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > --- > > max77693_charger.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> > --- a/drivers/power/max77693_charger.c > +++ b/drivers/power/max77693_charger.c > @@ -612,12 +612,8 @@ static int max77693_reg_init(struct max7 > if (ret) > return ret; > > - ret = max77693_set_charge_input_threshold_volt(chg, > + return max77693_set_charge_input_threshold_volt(chg, > chg->charge_input_threshold_volt); > - if (ret) > - return ret; > - > - return 0; > } > > #ifdef CONFIG_OF
| |