Messages in this thread | | | Date | Tue, 20 Jan 2015 08:20:13 +0000 | From | Lee Jones <> | Subject | Re: [PATCH RESEND v2 5/7] mfd: cros_ec: Instantiate ChromeOS EC character device |
| |
On Fri, 02 Jan 2015, Javier Martinez Canillas wrote:
> The ChromeOS EC character device is an user-space interface to > allow applications to access the Embedded Controller. > > Add a cell for this device so it's spawned from the mfd driver. > > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk> > --- > > Changes since v1: None, new patch. > > drivers/mfd/cros_ec.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c > index c872e1b..70f9ed5 100644 > --- a/drivers/mfd/cros_ec.c > +++ b/drivers/mfd/cros_ec.c > @@ -118,6 +118,10 @@ static const struct mfd_cell cros_devs[] = { > .id = 2, > .of_compatible = "google,cros-ec-i2c-tunnel", > }, > + { > + .name = "cros-ec-dev",
*-dev is seldom suitable for naming things.
Please be more imaginative/descriptive in your naming.
> + .id = 3, > + }, > }; > > int cros_ec_register(struct cros_ec_device *ec_dev)
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |