lkml.org 
[lkml]   [2015]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] crypto: aesni: add setkey for driver-gcm-aes-aesni
Date
Am Sonntag, 18. Januar 2015, 23:56:03 schrieb Stephan Mueller:

Hi Tadeusz,

> The cipher registered as __driver-gcm-aes-aesni is never intended
> to be used directly by any caller. Instead it is a service mechanism to
> rfc4106-gcm-aesni.
>
> The kernel crypto API unconditionally calls the registered setkey
> function. In case a caller erroneously uses __driver-gcm-aes-aesni a
> call to crypto_aead_setkey will cause a NULL pointer dereference without
> this patch.

I tested that patch and can confirm that this patch fixes the kernel crash
triggered through the AF_ALG interface for AEAD ciphers that is currently
under development reported earlier.
>
> CC: Tadeusz Struk <tadeusz.struk@intel.com>
> Signed-off-by: Stephan Mueller <smueller@chronox.de>
> ---
> arch/x86/crypto/aesni-intel_glue.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/x86/crypto/aesni-intel_glue.c
> b/arch/x86/crypto/aesni-intel_glue.c index 947c6bf..a278ef9 100644
> --- a/arch/x86/crypto/aesni-intel_glue.c
> +++ b/arch/x86/crypto/aesni-intel_glue.c
> @@ -1012,6 +1012,16 @@ static int rfc4106_decrypt(struct aead_request *req)
> }
> }
>
> +static int __driver_rfc4106_set_key(struct crypto_aead *parent,
> + const u8 *key, unsigned int key_len)
> +{
> + /*
> + * __driver-gcm-aes-aesni is only a backend for rfc4106-gcm-aesni
> + * and is never intended to be used as a regular cipher.
> + */
> + return -EOPNOTSUPP;
> +}
> +
> static int __driver_rfc4106_encrypt(struct aead_request *req)
> {
> u8 one_entry_in_sg = 0;
> @@ -1366,6 +1376,7 @@ static struct crypto_alg aesni_algs[] = { {
> .cra_module = THIS_MODULE,
> .cra_u = {
> .aead = {
> + .setkey = __driver_rfc4106_set_key,
> .encrypt = __driver_rfc4106_encrypt,
> .decrypt = __driver_rfc4106_decrypt,
> },


--
Ciao
Stephan


\
 
 \ /
  Last update: 2015-01-19 06:41    [W:0.152 / U:26.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site