lkml.org 
[lkml]   [2015]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] gpu: ipu-v3: wait_for_completion_timeout does not return negativ status
From
Date
Hi Nicholas,

thank you for the patch.

Am Freitag, den 16.01.2015, 11:48 +0100 schrieb Nicholas Mc Guire:
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
>
> Patch is against 3.19.0-rc3 -next-20150109
>
> This patch was compiletested with imx_v6_v7_defconfig +
> CONFIG_RESET_CONTROLLER=y, CONFIG_IMX_IPUV3_CORE=m
>
> drivers/gpu/ipu-v3/ipu-dc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/ipu-v3/ipu-dc.c b/drivers/gpu/ipu-v3/ipu-dc.c
> index 2326c75..0ffa659 100644
> --- a/drivers/gpu/ipu-v3/ipu-dc.c
> +++ b/drivers/gpu/ipu-v3/ipu-dc.c
> @@ -282,7 +282,7 @@ void ipu_dc_disable_channel(struct ipu_dc *dc)
> enable_irq(irq);
> ret = wait_for_completion_timeout(&priv->comp, msecs_to_jiffies(50));
> disable_irq(irq);
> - if (ret <= 0) {
> + if (ret == 0) {

In addition to this, I think ret should be changed to unsigned long.

regards
Philipp



\
 
 \ /
  Last update: 2015-01-19 09:21    [W:0.089 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site