lkml.org 
[lkml]   [2015]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 2/3] sysfs: Only accept read/write permissions for file attributes
Date
For sysfs file attributes, only read and write permisssions make sense.
Mask provided attribute permissions accordingly and send a warning
to the console if invalid permission bits are set.

Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
fs/sysfs/group.c | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/fs/sysfs/group.c b/fs/sysfs/group.c
index 305eccb..0de6473 100644
--- a/fs/sysfs/group.c
+++ b/fs/sysfs/group.c
@@ -55,6 +55,12 @@ static int create_files(struct kernfs_node *parent, struct kobject *kobj,
if (!mode)
continue;
}
+
+ WARN(mode & ~(S_IRUGO | S_IWUGO | SYSFS_PREALLOC),
+ "Attribute %s: Invalid permission 0x%x\n",
+ (*attr)->name, mode);
+
+ mode &= S_IRUGO | S_IWUGO | SYSFS_PREALLOC;
error = sysfs_add_file_mode_ns(parent, *attr, false,
mode, NULL);
if (unlikely(error))
--
2.1.0


\
 
 \ /
  Last update: 2015-01-19 23:01    [W:0.065 / U:20.692 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site