lkml.org 
[lkml]   [2015]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH net-next 1/7] r8152: adjust rx_bottom
From
From: Scott Feldman <sfeldma@gmail.com>
Date: Mon, 19 Jan 2015 00:03:42 -0800

> On Sun, Jan 18, 2015 at 11:13 PM, Hayes Wang <hayeswang@realtek.com> wrote:
>> @@ -1746,7 +1746,18 @@ find_next_rx:
>> }
>>
>> submit:
>> - r8152_submit_rx(tp, agg, GFP_ATOMIC);
>> + if (!ret) {
>> + ret = r8152_submit_rx(tp, agg, GFP_ATOMIC);
>> + } else {
>> + urb->actual_length = 0;
>> + list_add_tail(&agg->list, next);
>
> Do you need a spin_lock_irqsave(&tp->rx_lock, flags) around this?

Indeed, and rtl_start_rx() seems to also access agg->list without
proper locking.


\
 
 \ /
  Last update: 2015-01-19 22:21    [W:0.156 / U:1.984 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site