Messages in this thread | | | Date | Mon, 19 Jan 2015 21:10:50 +0000 | From | Al Viro <> | Subject | Re: [RFC 1/2] FS: mount_bdev from vfs instead of filesystem specific mount function. |
| |
On Mon, Jan 19, 2015 at 09:47:20PM +0100, Fabian Frederick wrote: > Currently, a lot of filesystem mounting functions feature in > file_system_type only to be called from vfs mount_fs and call mount_bdev. > > This patch adds fill_super function to that structure and lets vfs > call mount_bdev when no mount function is declared.
NAK. First of all, quite a few of them are _not_ mount_bdev() users. What's more, you are trading about 4 lines per filesystem (two of them being { and }) for a layering violation.
No point whatsoever. fill_super() is no more a method than e.g. get_block().
| |