lkml.org 
[lkml]   [2015]   [Jan]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: module: fix module_refcount() return when running in a module exit routine
From
Date
On Mon, 2015-01-19 at 00:28 -0800, Christoph Hellwig wrote:
> On Mon, Jan 19, 2015 at 04:21:15PM +1030, Rusty Russell wrote:
> > The first one I think should be eliminated, and the second one is simply
> > an assertion before calling module_put() (which should probably be
> > eliminated). The others are just printing information.
>
> FYI, I've got a pathcset to eliminate the use of module_refcount in
> SCSI, which was a horrible hack to start with, but it needs a little more
> clarification / work, so I'd prefer to do it for 3.20. Bart has a fix
> that eliminates it for 3.19, which piles aother bandaid over the bandaid
> that introduced the use module_refcount, and James doesn't seem to like
> it.

I don't like adding another refcount where one already exists because
it's pointless duplication. Rusty's fix is fine because it captures the
intention of the use in scsi_device_get, so let's go with it. You can
add an Acked-by from me to his patch.

James





\
 
 \ /
  Last update: 2015-01-19 17:21    [W:0.138 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site