Messages in this thread | | | Date | Mon, 19 Jan 2015 15:23:00 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: speakup: Fix warning of line over 80 characters. |
| |
Generally this patch is fine. There were a couple places which weren't perfect.
On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote: > + if ((spk_bleeps & 2) && (msg_id < edge_quiet)) { > + synth_printf("%s\n", > + spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1)); > + }
This should be:
if ((spk_bleeps & 2) && (msg_id < edge_quiet)) { synth_printf("%s\n", spk_msg_get(MSG_EDGE_MSGS_START + msg_id - 1)); }
> +#define spk_serial_tx_busy() \ > +((inb(speakup_info.port_tts + UART_LSR) & BOTH_EMPTY) != BOTH_EMPTY)
This should be:
#define spk_serial_tx_busy() \ ((inb(speakup_info.port_tts + UART_LSR) & BOTH_EMPTY) != BOTH_EMPTY)
Otherwise this patch is nice. I'm fine with merging it as-is if people want.
regards, dan carpenter
| |