lkml.org 
[lkml]   [2015]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dell-laptop: use dedicated sysfs file for ALS
On Wed, Jan 14, 2015 at 03:07:21PM +0100, Gabriele Mazzotta wrote:
> Hi,
>
> I decided to remove "als" from input_triggers and created a dedicated
> sysfs file for it. Having it there was wrong and misleading.
> I also updated the documentation to reflect this change and fixed the
> wrong description of als_setting, now used for als_enabled.

Given this is a significant functional change, as opposed to a bug fix, I'm
leaning toward reverting the original and adding back the corrected version to
3.20. I'm going to look at the total impact first - let me know if you have a
strong argument one way or the other.

>
> Is returning -ENODEV only when writing to als_enabled the right thing
> to do or should it be returned also when reading als_enabled?

Why would the als_enabled file exist if it would return ENODEV? If it shouldn't,
then returning ENODEV in both cases would be the right thing to do as there is
an error present.

--
Darren Hart
Intel Open Source Technology Center


\
 
 \ /
  Last update: 2015-01-18 19:21    [W:0.232 / U:0.612 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site