lkml.org 
[lkml]   [2015]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] clk: qcom: Add EBI2 clocks for IPQ806x
    On 01/16/2015 06:48 AM, Archit Taneja wrote:
    > The NAND controller within EBI2 requires EBI2_CLK and EBI2_ALWAYS_ON_CLK clocks.
    > Create structs for these clocks so that they can be used by the NAND controller
    > driver. Add an entry for EBI2_AON_CLK in the gcc-ipq806x DT binding document.
    >
    > Cc: Stephen Boyd <sboyd@codeaurora.org>
    > Signed-off-by: Archit Taneja <architt@codeaurora.org>

    Looks ok. I couldn't find this used in the downstream sources though.
    Can you point me to it? I'm mostly worried that this is a shared
    resource that never should be turned off, so exposing it to drivers may
    not be the right idea.

    > +static struct clk_branch ebi2_aon_clk = {
    > + .hwcg_reg = 0x3b00,
    > + .hwcg_bit = 6,
    > + .halt_reg = 0x2fcc,
    > + .halt_bit = 0,
    > + .clkr = {
    > + .enable_reg = 0x3b00,
    > + .enable_mask = BIT(8),
    > + .hw.init = &(struct clk_init_data){
    > + .name = "ebi2_always_on_clk",
    >

    Can this be ebi2_aon_clk to match the macro?

    --
    Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
    a Linux Foundation Collaborative Project



    \
     
     \ /
      Last update: 2015-01-16 23:01    [W:4.590 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site