lkml.org 
[lkml]   [2015]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration
Jia He,

Your patch is looking better :-)
A few nits though.

On Fri, Jan 16, 2015 at 04:58:12PM +0800, Jia He wrote:
> These functions kportal_memhog_{alloc,free} aren't used outside of
^^^^^ Don't indent paragraphs, just use a line between paragraphs.
> this file, so making them static to suppress the sparse warnings about
> static declaration.

> Besides, this also fixes the space warning checked by checkpatch.pl
"Besides" doesn't sound right here. I would just say something like
"Also fix the space warning ..."

In your subject line it is helpful to add a version number so people
can tell that this is a new revision. For example: [PATCH v2].
git format-patch can add this automatically with the '-v' option.

[...]

--
- Jeremiah Mahler


\
 
 \ /
  Last update: 2015-01-16 20:21    [W:0.084 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site