| Date | Fri, 16 Jan 2015 20:01:54 +0100 | From | Borislav Petkov <> | Subject | Re: [patch 13/23] x86/smpboot: Move smpboot inlines to code |
| |
On Thu, Jan 15, 2015 at 09:22:29PM -0000, Thomas Gleixner wrote: > No point for a seperate header file.
s/seperate/separate/
> > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > --- > arch/x86/include/asm/smpboot_hooks.h | 68 ----------------------------------- > arch/x86/kernel/smpboot.c | 67 +++++++++++++++++++++++++++++++++- > 2 files changed, 66 insertions(+), 69 deletions(-)
...
> +static inline void __init smpboot_setup_io_apic(void) > +{ > +#ifdef CONFIG_X86_IO_APIC > + /* > + * Here we can be sure that there is an IO-APIC in the system. Let's > + * go and set it up: > + */ > + if (!skip_ioapic_setup && nr_ioapics) > + setup_IO_APIC(); > + else { > + nr_ioapics = 0; > + }
No need for those braces.
> +#endif > +} > + > +static inline void smpboot_clear_io_apic(void) > +{ > +#ifdef CONFIG_X86_IO_APIC > + nr_ioapics = 0; > +#endif > +} > + > /* > * Report back to the Boot Processor during boot time or to the caller processor > * during CPU online.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply. --
|