Messages in this thread | | | Date | Fri, 16 Jan 2015 12:02:02 +0100 | From | Michal Simek <> | Subject | Re: [PATCH 2/2] tty: serial: 8250_core: Check that port->line is >=0 |
| |
On 01/16/2015 11:51 AM, Sebastian Andrzej Siewior wrote: > - Yoshihiro YUNOMAE > (reason: 550 5.1.1 <yoshihiro.yunomae.ez@hitachi.com>: Recipient > address rejected: User Unknown) > > On 01/16/2015 11:37 AM, Michal Simek wrote: >> Hi, > > Hi, > >> Origin patch looks good to me but this checking will be good to add. >> Are you using of_serial.c because I didn't find any of_alias_get_id call >> for 8250? > > I'm using of_alias_get_id() in 8250_omap.c which made it into > v3.19-rc1. I think the change you mention made it one release earlier.
I see serial: of-serial: fetch line number from DT commit 1bd8324535ec1ff44aef55c0e40b9e7d56b310fb
but it was reverted
Revert "serial: of-serial: fetch line number from DT" commit e4c787dac21e50ac9ef53fac91b9182d4fede465
Olof: what was the reason for that breakage? Is it missing alias list on Tegra? which caused that port->line number is bogus.
Thanks, Michal
| |