Messages in this thread | | | Date | Thu, 15 Jan 2015 16:41:32 -0700 | From | Shuah Khan <> | Subject | Re: [PATCH v4 20/20] kbuild: add a new kselftest_install make target to install selftests |
| |
On 01/15/2015 03:58 PM, Michael Ellerman wrote: > On Wed, 2015-01-14 at 09:32 -0700, Shuah Khan wrote: >> On 01/06/2015 12:43 PM, Shuah Khan wrote: >>> Add a new make target to install to install kernel selftests. >>> This new target will build and install selftests. kselftest >>> target now depends on kselftest_install and runs the generated >>> kselftest script to reduce duplicate work and for common look >>> and feel when running tests. >>> >>> make kselftest_target: >>> -- exports kselftest INSTALL_KSFT_PATH >>> default $(INSTALL_MOD_PATH)/lib/kselftest/$(KERNELRELEASE) >>> -- exports INSTALL_KSFT_PATH >>> -- runs selftests make install target >>> >>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com> >> >> Hi Marek, >> >> Could you please Ack this patch, if this version looks good, >> so I can take this through ksefltest tree. > > Hi Shuah, > > I posted what I think is a better approach last week. It's less code and less > repetition, and installs the majority of tests this series missed - ie. the > powerpc ones. > > Please at least respond to it before you put this series into next. > > https://lkml.org/lkml/2015/1/9/45 >
Michael,
I didn't get a chance to review your patches yet. I plan to review and give you feedback by end of this week. This patch is needed in any case for either approach.
thanks, -- Shuah
-- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978
| |