Messages in this thread | | | Date | Thu, 15 Jan 2015 15:41:10 -0800 | From | Tyrel Datwyler <> | Subject | Re: [PATCH] pseries/le: Fix another endiannes issue in RTAS call from xmon |
| |
On 01/15/2015 02:19 PM, Michael Ellerman wrote: > On Thu, 2015-01-15 at 11:44 -0800, Tyrel Datwyler wrote: >> On 01/15/2015 09:23 AM, Laurent Dufour wrote: >>> The commit 3b8a3c010969 ("powerpc/pseries: Fix endiannes issue in RTAS >>> call from xmon") was fixing an endianness issue in the call made from >>> xmon to RTAS. >>> >>> However, as Michael Ellerman noticed, this fix was not complete, the >>> token value was not byte swapped. This lead to call an unexpected and >>> most of the time unexisting RTAS function, which is silently ignored >>> by RTAS. >> >> Nit. Not so much that is silently ignored by RTAS as much as >> disable_surveillance silently doesn't check the return status of the >> RTAS call. Maybe a check is warranted and reporting of non-success. > > Yeah you're right, I added a printf of the result and got -3, which is also > wrong as far as I can tell, but I didn't have the energy to chase it any > further.
If this was on a powerkvm guest set-indicator should be present for hotplug (DLPAR) support. However, the surveillance indicator would not be implemented. I know sometimes I forget if I'm on a powervm or powerkvm guest. Just a thought.
-Tyrel
> > Because this is in xmon we want to be extra careful about what we do, but an > xmon_printf() should be safe. I'll do that as a cleanup after this. > > cheers > >
| |