lkml.org 
[lkml]   [2015]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 03/11] ARM: tegra: Set the sound card model that alsaucm expects
On 01/15/2015 09:12 AM, Tomeu Vizoso wrote:
> Patches are on its way to add a config file to alsaucm for the Nyan
> boards. Use the same card ID that alsaucm will expect.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> ---
> arch/arm/boot/dts/tegra124-nyan-big.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/tegra124-nyan-big.dts b/arch/arm/boot/dts/tegra124-nyan-big.dts
> index 43e58a4..9a9cffe 100644
> --- a/arch/arm/boot/dts/tegra124-nyan-big.dts
> +++ b/arch/arm/boot/dts/tegra124-nyan-big.dts
> @@ -1976,9 +1976,9 @@
> };
>
> sound {
> - compatible = "nvidia,tegra-audio-max98090-nyan-big",
> + compatible = "nvidia,tegra-audio-max98090-nyan",
> "nvidia,tegra-audio-max98090";

If all the boards that are derived from Nyan truly have identical audio
HW (or at least any differences can be described by this binding), then
it seems fine to add "nvidia,tegra-audio-max98090-nyan" to the
compatible value.

However, I don't see a reason to remove the board-specific compatible
value "nvidia,tegra-audio-max98090-nyan-big"; we should always include
all the values that are relevant.

> - nvidia,model = "Acer Chromebook 13";
> + nvidia,model = "GoogleNyan";

Why not just name the UCM config file after the ASoC card name that's
already in use? Perhaps it's not likely to be unique enough though:-(


\
 
 \ /
  Last update: 2015-01-15 18:41    [W:0.180 / U:1.468 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site