Messages in this thread | | | Date | Thu, 15 Jan 2015 09:04:48 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 2/3] ftrace: Check both notrace and filter for old hash |
| |
On Thu, 15 Jan 2015 19:59:36 +0900 Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> > @@ -3637,6 +3639,7 @@ int > > register_ftrace_function_probe(char *glob, struct ftrace_probe_ops > > *ops, void *data) > > { > > + struct ftrace_ops_hash old_hash_ops; > > Would it be better to be old_ops_hash? since it's not an ops.
Probably. I'll fix it for 3.20. I ran this through 9 hours of testing and I don't want to change anything unless I need to (if something else needs to change, I'll make this fix). Even a comment fix needs to go through my testing before I send to Linus (I was burnt by a comment fix that wasn't tested a long time ago, you never know what you might accidentally change).
> > Other parts are OK for me :) > > Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> >
Thanks!
-- Steve
| |