lkml.org 
[lkml]   [2015]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2 v2] ftrace: don't allow IPMODIFY without proper compiler support
On Thu, 15 Jan 2015, Masami Hiramatsu wrote:

> Hmm, if this binary doesn't support IPMODIFY, it should return -ENOTSUPP.

Good poing, will send v3.

> And also, IMHO, we'd better reject registering ftrace_ops with IPMODIFY
> in this situation before updating hash table.

That would happen automatically if we return -ENOTSUPP, right? Because the
check in ftrace_hash_move() would cause freeing of the new_hash and the
error value would get propagated out to ftrace_hash_move() callers.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2015-01-15 10:41    [W:0.081 / U:1.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site