lkml.org 
[lkml]   [2015]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] RTC: RK808: fix the rtc time reading issue
From
Chris,

On Tue, Jan 13, 2015 at 6:43 PM, Chris Zhong <zyw@rock-chips.com> wrote:
> + /* After we set the GET_TIME bit, the rtc time couldn't be read
> + * immediately, we should wait up to 31.25 us, about one cycle of
> + * 32khz. If we clear the GET_TIME bit here, the time of i2c transfer
> + * certainly more than 31.25us.
> + */

No idea what Andrew thinks of this, but other multiline comments in
this file look slightly different (there's a line containing just /*).


> ret = regmap_update_bits(rk808->regmap, RK808_RTC_CTRL_REG,
> BIT_RTC_CTRL_REG_RTC_GET_TIME,
> - BIT_RTC_CTRL_REG_RTC_GET_TIME);
> + 0);
> if (ret) {
> dev_err(dev, "Failed to update bits rtc_ctrl: %d\n", ret);
> return ret;

Above is just a nit. I'll leave it up to Andrew to say whether he
wants you to spin, or he'll fix it up, or he doesn't care and he'll
land it as-is.

Reviewed-by: Doug Anderson <dianders@chromium.org>


\
 
 \ /
  Last update: 2015-01-14 20:01    [W:1.711 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site