lkml.org 
[lkml]   [2015]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v3 06/16] virtio/scsi: verify device has config space
    Some devices might not implement config space access
    (e.g. remoteproc used not to - before 3.9).
    virtio/scsi needs config space access so make it
    fail gracefully if not there.

    Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
    ---
    drivers/scsi/virtio_scsi.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
    index c52bb5d..f164f24 100644
    --- a/drivers/scsi/virtio_scsi.c
    +++ b/drivers/scsi/virtio_scsi.c
    @@ -950,6 +950,12 @@ static int virtscsi_probe(struct virtio_device *vdev)
    u32 num_queues;
    struct scsi_host_template *hostt;

    + if (!vdev->config->get) {
    + dev_err(&vdev->dev, "%s failure: config access disabled\n",
    + __func__);
    + return -EINVAL;
    + }
    +
    /* We need to know how many queues before we allocate. */
    num_queues = virtscsi_config_get(vdev, num_queues) ? : 1;

    --
    MST


    \
     
     \ /
      Last update: 2015-01-14 19:01    [W:3.413 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site