lkml.org 
[lkml]   [2015]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] Use of_get_child_by_name() instead of of_find_node_by_name()
Date
	Hi Ben, Bryan/Richard, Jingoo/Lee,

Internally, of_find_node_by_name() calls of_node_put() on its "from"
parameter. This is a problem if that device_node will be used
afterwards, or if of_node_put() is called on it again (either manually
or in a for_each_*_node() loop) later, as that may cause a zero kref
refcount. This may be caught by the system if CONFIG_OF_DYNAMIC=y:

ERROR: Bad of_node_put() on /....

Use of_get_child_by_name() instead to fix this, and remove existing
workarounds to pre-increase the refcount.

Compile-tested only.

Geert Uytterhoeven (3):
powerpc/pmac: Fix DT refcount imbalance in pmac_pic_probe_oldstyle
leds: leds-mc13783: Use of_get_child_by_name() instead of refcount
hack
backlight: 88pm860x_bl: Use of_get_child_by_name() instead of refcount
hack

arch/powerpc/platforms/powermac/pic.c | 2 +-
drivers/leds/leds-mc13783.c | 4 +---
drivers/video/backlight/88pm860x_bl.c | 5 +----
3 files changed, 3 insertions(+), 8 deletions(-)

--
1.9.1

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2015-01-14 15:21    [W:0.118 / U:40.292 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site