lkml.org 
[lkml]   [2015]   [Jan]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/3] backlight: 88pm860x_bl: Use of_get_child_by_name() instead of refcount hack
    Date
    of_find_node_by_name() calls of_node_put() on its "from" parameter.
    To counter this, pm860x_backlight_dt_init() calls of_node_get() first.

    Use of_get_child_by_name() instead to get rid of the refcount hack.

    Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
    Cc: linux-fbdev@vger.kernel.org
    ---
    Compile-tested only
    ---
    drivers/video/backlight/88pm860x_bl.c | 5 +----
    1 file changed, 1 insertion(+), 4 deletions(-)

    diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c
    index 9a23698b6fe8398c..2da5862876d1fe78 100644
    --- a/drivers/video/backlight/88pm860x_bl.c
    +++ b/drivers/video/backlight/88pm860x_bl.c
    @@ -168,10 +168,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev,
    struct device_node *nproot, *np;
    int iset = 0;

    - nproot = of_node_get(pdev->dev.parent->of_node);
    - if (!nproot)
    - return -ENODEV;
    - nproot = of_find_node_by_name(nproot, "backlights");
    + nproot = of_get_child_by_name(pdev->dev.parent->of_node, "backlights");
    if (!nproot) {
    dev_err(&pdev->dev, "failed to find backlights node\n");
    return -ENODEV;
    --
    1.9.1


    \
     
     \ /
      Last update: 2015-01-14 15:21    [W:2.714 / U:0.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site