Messages in this thread Patch in this message | | | From | Andrey Tsyvarev <> | Subject | [PATCH] kernel/module.c: Free lock-classes if parse_args failed | Date | Wed, 14 Jan 2015 09:25:08 +0300 |
| |
parse_args call module parameters' .set handlers, which may use locks defined in the module. So, these classes should be freed in case parse_args returns error(e.g. due to incorrect parameter passed).
Signed-off-by: Andrey Tsyvarev <tsyvarev@ispras.ru> --- kernel/module.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/kernel/module.c b/kernel/module.c index 3965511..2b44de4 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -3311,6 +3311,9 @@ static int load_module(struct load_info *info, const char __user *uargs, module_bug_cleanup(mod); mutex_unlock(&module_mutex); + /* Free lock-classes: */ + lockdep_free_key_range(mod->module_core, mod->core_size); + /* we can't deallocate the module until we clear memory protection */ unset_module_init_ro_nx(mod); unset_module_core_ro_nx(mod); -- 1.8.3.1
| |