lkml.org 
[lkml]   [2015]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 3/7] gpio/xilinx: Add support for X86 Arch
From
Date
On Wed, 2014-12-17 at 16:51 +0100, Ricardo Ribalda Delgado wrote:
> Core can be accessed via PCIe on X86 platform.
> This patch also allows the driver to be used as module.
>
> Acked-by: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> drivers/gpio/Kconfig | 4 ++--
> drivers/gpio/gpio-xilinx.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)

This patch became c586b3075d5b ("gpio/xilinx: Add support for X86 Arch")
in today's linux-next (next-20150113). I noticed because a script I use
to check linux-next spotted a problem in it.

> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 414d055..b17d226 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -366,8 +366,8 @@ config GPIO_XGENE
> here to enable the GFC GPIO functionality.
>
> config GPIO_XILINX
> - bool "Xilinx GPIO support"
> - depends on PPC_OF || MICROBLAZE || ARCH_ZYNQ
> + tristate "Xilinx GPIO support"
> + depends on OF_GPIO && (PPC_OF || MICROBLAZE || ARCH_ZYNQ || ARCH_X86)

There's no Kconfig symbol "ARCH_X86". Did you actually mean "X86"?

> help
> Say yes here to support the Xilinx FPGA GPIO device
>
> diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c
> index c7ed92b..554060a 100644
> --- a/drivers/gpio/gpio-xilinx.c
> +++ b/drivers/gpio/gpio-xilinx.c
> @@ -30,7 +30,7 @@
> #define XGPIO_CHANNEL_OFFSET 0x8
>
> /* Read/Write access to the GPIO registers */
> -#ifdef CONFIG_ARCH_ZYNQ
> +#if defined(CONFIG_ARCH_ZYNQ) || defined(CONFIG_X86)

Yes, you probably did want just "X86".

> # define xgpio_readreg(offset) readl(offset)
> # define xgpio_writereg(offset, val) writel(val, offset)
> #else


Paul Bolle



\
 
 \ /
  Last update: 2015-01-13 10:41    [W:0.159 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site