| Date | Tue, 13 Jan 2015 16:55:05 -0500 | From | Matthew Wilcox <> | Subject | Re: [PATCH v12 09/20] dax,ext2: Replace xip_truncate_page with dax_truncate_page |
| |
On Mon, Jan 12, 2015 at 03:09:58PM -0800, Andrew Morton wrote: > > + * Similar to block_truncate_page(), this function can be called by a > > + * filesystem when it is truncating an DAX file to handle the partial page. > > + * > > + * We work in terms of PAGE_CACHE_SIZE here for commonality with > > + * block_truncate_page(), but we could go down to PAGE_SIZE if the filesystem > > + * took care of disposing of the unnecessary blocks. > > But PAGE_SIZE==PAGE_CACHE_SIZE. Unclear what you're saying here.
The last I heard, some people were trying to resurrect the PAGE_CACHE_SIZE > PAGE_SIZE patches. I'd be grateful if the distinction between PAGE_SIZE and PAGE_CACHE_SIZE went away, tbh.
|