| Date | Tue, 13 Jan 2015 10:59:51 -0500 | From | Rik van Riel <> | Subject | Re: [RFC PATCH 01/11] x86,fpu: document the data structures a little |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/12/2015 04:52 PM, Dave Hansen wrote: > On 01/11/2015 01:46 PM, riel@redhat.com wrote: >> +/* + * The FPU state used depends on the capabilities of the >> hardware; the + * registers used for vector instructions on newer >> hardware are included + * in the FPU state. + */ union >> thread_xstate { > > Tiny nit, if you happen to revise this set at some point... > > While you probably don't need/want to have an exhaustive list of > everything that gets saved in there, we should probably still > mention that it's a lot more than just vector instructions. > > I'd say: > > The FPU state used depends on the capabilities of the hardware. > This state increasingly contains things not related to the FPU > itself, like registers used for vector instructions. > I like it. I replaced my comment with your improved one.
- -- All rights reversed -----BEGIN PGP SIGNATURE----- Version: GnuPG v1
iQEcBAEBAgAGBQJUtUD3AAoJEM553pKExN6D9vAIAJg02XYwxLoJYWAEDOn7SxWc Y18RGzaE8YIM0GLevMdOAu5EJ9IitZzHG/I7dBPr0j7ATwOZrjfg6WsS02Eonk8P yLS/NQFUWb4bkjPYJNdyrM76BLr2diEHdS2aw97sBXiVrM2SVVu0o45GU8pc241X WGPV4G3TlyTgJLxAn0+kbvBF0PZhEEHhTP4QPkIjqht8/q9DKOC7dPaQA8aUYYVy ISXSsg7gHCZ9KcBGmgx90kFLKDwLC6H8lV8MCe7tZDyof/mvpuNcZY843YV/uZNK /DeMrSbdVJgyau73HZXt8Fm42G56PiA79/kluuQc7rXBk4tcwu/t/DxX0wbD6WE= =3Vvs -----END PGP SIGNATURE-----
|