lkml.org 
[lkml]   [2015]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] ALSA: ASoC: soc-compress.c: fix NULL dereference
On Tue, Jan 13, 2015 at 03:16:10PM +0000, Qais Yousef wrote:
> On 01/13/2015 02:59 PM, Vinod Koul wrote:

> >>being NULL, hence when trying to set rtd a few lines below we get an oops.
> >It is a good practice to add the oops here

> Will this really be helpful? I think it'll be more clutter (the backtrace on
> metag arch is not great):

It's better in general to leave it out unless it's adding something (for
example sometimes the particular call path is important) and even there
edit it down to relevant details - the splat from the full oops normally
overwhelms the commit message.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-01-13 17:41    [W:0.063 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site