Messages in this thread | | | Date | Mon, 12 Jan 2015 21:07:15 -0800 | From | Brian Norris <> | Subject | Re: [PATCH v3 08/13] mtd: st_spi_fsm: Update the JEDEC probe to handle extended READIDs |
| |
On Mon, Dec 15, 2014 at 11:59:15AM +0000, Lee Jones wrote: > The previous code was based on 3-byte JEDEC IDs, with a possible 2-byte > extension. However, devices are now emerging that return 6 or more bytes of > READID data and the additional bytes are required to differentiate between > variants or generations of similar devices. > > This patch refactors the device table and JEDEC probe code to handle arbitrary > length READIDs, with the standard JEDEC definition now becoming a special case. > Functionally, there should be no change in behaviour. A subsequent patch will > update the table with extended READIDs where applicable.
BTW, how's that promise going, where you work on adapting this driver to the spi-nor framework? We've already done some of this same work there.
> +#define RDID(...) __VA_ARGS__ /* Dummy macro to protect array argument. */
What? What needs "protected"?
...
Brian
| |