lkml.org 
[lkml]   [2015]   [Jan]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/3] gpio: sysfs: fix attribute leaks and races
Date
Here are three more patches for 3.19 fixing some long-standing memory
leaks and races (with userspace) in the gpio sysfs-interface
implementation.

The memory leaks are marked for stable, but I'll need to backport them
to pre-3.18 kernels once they are upstream due to commit 0eb4c6c2671c
("gpio: move sysfs support to its own file").

I chose not to mark the final patch for stable as the attribute-creation
race with userspace (e.g. udev rule) is not as critical (and patch a bit
more invasive).

Please note that these patches will cause a conflict with 3511ee7b3312
("gpio: lib-sysfs: Add 'wakeup' attribute") in gpio/devel, which adds
yet another device attribute without ever removing it. Unless the commit
in question can be reverted, that leak could be fixed as part of the
merge resolution, I guess.

Johan


Johan Hovold (3):
gpio: sysfs: fix gpio-chip device-attribute leak
gpio: sysfs: fix gpio device-attribute leak
gpio: sysfs: fix gpio attribute-creation race

drivers/gpio/gpiolib-sysfs.c | 92 +++++++++++++++++++++++++-------------------
drivers/gpio/gpiolib.h | 1 +
2 files changed, 53 insertions(+), 40 deletions(-)

--
2.0.5



\
 
 \ /
  Last update: 2015-01-13 13:41    [W:0.130 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site