Messages in this thread | | | Date | Tue, 13 Jan 2015 12:49:17 +0200 | From | Tomi Valkeinen <> | Subject | Re: [PATCH] video: ocfb: Fix data type warning |
| |
On 05/12/14 10:18, Qiang Chen wrote: > When allocate framebuffer memory using dma_alloc_coherent(), > we'd better use dma_addr_t instead of phys_addr_t. Because the > address we got in fact is DMA or bus address for the platform. > > This patch also fixes below build warning: > drivers/video/fbdev/ocfb.c:335:2: > warning: passing argument 3 of ‘dma_alloc_attrs’ > from incompatible pointer type [enabled by default] > > Signed-off-by: Qiang Chen <qiang2.chen@sonymobile.com> > --- > drivers/video/fbdev/ocfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/ocfb.c b/drivers/video/fbdev/ocfb.c > index 7f9dc9b..de98196 100644 > --- a/drivers/video/fbdev/ocfb.c > +++ b/drivers/video/fbdev/ocfb.c > @@ -61,7 +61,7 @@ struct ocfb_dev { > /* flag indicating whether the regs are little endian accessed */ > int little_endian; > /* Physical and virtual addresses of framebuffer */ > - phys_addr_t fb_phys; > + dma_addr_t fb_phys; > void __iomem *fb_virt; > u32 pseudo_palette[PALETTE_SIZE]; > }; >
Thanks, queued for 3.20.
Tomi
[unhandled content-type:application/pgp-signature] | |