Messages in this thread | | | Date | Tue, 9 Sep 2014 08:34:46 +0100 | From | Peter Griffin <> | Subject | Re: [PATCH 2/3] phy: phy-stih407-usb: Add dt documentation for USB picophy found on stih407 SoC family |
| |
Hi Kishon,
Thanks for reviewing :-)
> > +On STiH410, we have to use the DWC3 port#2 with a picoPHY to manage USB2 > > +devices. The USB2 Controller will use the ports #0 and #1. > > + > > +This is to document the DT parameters to be passed from the blob in that case. > > + > > +Required properties: > > +- compatible : should be "st,stih407-usb2-phy" > > If STiH410 also uses the same driver then you should add a new compatibility > value for it.
I will remove the reference to stih410 in V2, as currently it is not supported upstream, and I'm not sure what ST's plans are regarding upstreaming it. If/ when it is upstreamed, we can add this and a compabible property back in.
<snip> > > + > > +usb2_picophy0: usbpicophy@0 { > usbpicophy@f8 since you have a reg property ;-)
will fix in V2
> > > + compatible = "st,stih407-usb2-phy"; > > + reg = <0xf8 0x04>, /* syscfg 5062 */ > > + <0xf4 0x04>; /* syscfg 5061 */ > > + reg-names = "param", > > + "ctrl"; > > + #phy-cells = <0>; > > alignment seems to have gone wrong here.
Will fix in v2
regards,
Peter.
| |