lkml.org 
[lkml]   [2014]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V1] ASoC: fsl_ssi: refine ipg clock usage in this module
On 09/09/2014 02:59 PM, Nicolin Chen wrote:
> + /*
> + * Initially mark the clock to NULL for all platforms so that later
> + * clk_prepare_enable() will ignore and return 0 for non-clock cases.
> + */
> + ssi_private->clk = NULL;

According to Mark, NULL is a valid clock, so this should be instead:

ssi_private->clk = PTR_ERR(-EINVAL);

although that doesn't sit well with me.


\
 
 \ /
  Last update: 2014-09-09 22:41    [W:0.069 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site