lkml.org 
[lkml]   [2014]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] drivers: target: target_core_transport.c: build warning
Date
build is giving : 
warning: passing argument 1 of 'strlen' makes pointer from integer
without a cast [enabled by default]

the snprintf after the strlen is trying to put the "Unsupported" string
at the end of exising string. so len should give the string length here

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/target/target_core_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 1dd1181..3ce85ed 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -953,7 +953,7 @@ int transport_dump_vpd_ident_type(
strlcat(buf, "SCSI name string\n", sizeof(buf));
break;
default:
- len = strlen(len);
+ len = strlen(buf);
snprintf(&buf[len], sizeof(buf) - len, "Unsupported: 0x%02x\n",
vpd->device_identifier_type);
ret = -EINVAL;
--
1.8.1.2


\
 
 \ /
  Last update: 2014-09-09 10:01    [W:0.057 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site