lkml.org 
[lkml]   [2014]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] virtio_blk: merge S/G list entries by default
On Sun, Sep 07, 2014 at 08:47:45PM +0200, Christoph Hellwig wrote:
> On Sun, Sep 07, 2014 at 02:41:53PM +0300, Michael S. Tsirkin wrote:
> > > Signed-off-by: Christoph Hellwig <hch@lst.de>
> >
> > OK so this is an optimization patch right?
> > What kind of performance gain is observed with it?
>
> None. I actually wrote it when the block layer had a bug when dm was
> used on top of the !merge case, and I decided to send it out as there had been
> no discussion about disabling this by default on the existing blk-mq
> drivers.
>
> At least for my qemu/kvm setup it doesn't make a difference either way,
> although not doing the cheap merge doesn't like the right kind of optimization
> to me.

Could you respond to Ming Lei's mail, who benchmarked the patch, please?

--
MST


\
 
 \ /
  Last update: 2014-09-08 11:01    [W:0.154 / U:1.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site