lkml.org 
[lkml]   [2014]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver
Date
> >
> > +#ifdef CONFIG_OF_GPIO
> > +
> > +static struct dwapb_platform_data *
> > +dwapb_gpio_get_pdata_of(struct device *dev) {
> > + struct device_node *node, *port_np;
> > + struct dwapb_platform_data *pdata;
> > + struct dwapb_port_property *pp;
> > + int nports;
> > + int i;
> > +
> > + node = dev->of_node;
> > + if (!node)
> > + return ERR_PTR(-ENODEV);
>
> Please replace the #ifdef above with
>
> if (!IS_ENABLED(CONFIG_OF_GPIO) || !node)
>
> here so get you proper compile-time coverage of the DT code path.
OK, I will improve it.


\
 
 \ /
  Last update: 2014-09-09 04:01    [W:1.963 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site