Messages in this thread | | | From | "Chen, Alvin" <> | Subject | RE: [PATCH 1/3 v2] GPIO: gpio-dwapb: Enable platform driver binding to MFD driver | Date | Tue, 9 Sep 2014 01:20:29 +0000 |
| |
> > > > +#ifdef CONFIG_OF_GPIO > > + > > +static struct dwapb_platform_data * > > +dwapb_gpio_get_pdata_of(struct device *dev) { > > + struct device_node *node, *port_np; > > + struct dwapb_platform_data *pdata; > > + struct dwapb_port_property *pp; > > + int nports; > > + int i; > > + > > + node = dev->of_node; > > + if (!node) > > + return ERR_PTR(-ENODEV); > > Please replace the #ifdef above with > > if (!IS_ENABLED(CONFIG_OF_GPIO) || !node) > > here so get you proper compile-time coverage of the DT code path. OK, I will improve it.
| |