lkml.org 
[lkml]   [2014]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] driver core: fix race with userland in device_add()
On Wed, Aug 06, 2014 at 04:18:38PM -0400, Alan Stern wrote:
> On Wed, 6 Aug 2014, Sergey Klyaus wrote:
>
> > Hello.
> >
> > I wrote a patch that fixes the problem that described above, here are a
> > patch for 3.16.0+ kernel (cloned from GitHub today). Maybe that "if
> > (MAJOR(dev->devt)) " part has to go even after BUS_NOTIFY_ADD_DEVICE abd
> > KOBJ_ADD? I put it before it, because there is no rollback code in
> > device_add() for that part.
>
> I think this is fine. However, I suspect the order of the other calls
> there isn't totally right. For instance, the
>
> if (parent)
> klist_add_tail(&dev->p->knode_parent,
> &parent->p->klist_children);
>
> part should probably be the first thing after we know the routine can't
> abort.
>
> I guess the time when bus_probe_device() gets called doesn't matter
> much, because the driver might not even be loaded at this point. But
> what about all the dev->class stuff at the end of device_add()? Should
> that happen before any uevents are sent out?
>
> Greg, have you looked at this?

I haven't, given that it's not in a format that I could apply it in,
even if I wanted to :(

greg k-h


\
 
 \ /
  Last update: 2014-09-09 01:21    [W:0.122 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site