lkml.org 
[lkml]   [2014]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: staging: lustre: Fix "space prohibited after that open parenthesis '('" errors
From
Date
On Mon, 2014-09-08 at 17:32 -0500, Greg Donald wrote:
> Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors
[]
> diff --git a/drivers/staging/lustre/lustre/obdclass/obdo.c b/drivers/staging/lustre/lustre/obdclass/obdo.c
[]
> @@ -161,35 +161,35 @@ int obdo_cmp_md(struct obdo *dst, struct obdo *src, u32 compare)
> {
> int res = 0;
>
> - if ( compare & OBD_MD_FLATIME )
> + if (compare & OBD_MD_FLATIME)
> res = (res || (dst->o_atime != src->o_atime));

These would be nicer as

res |= dst->o_atime != src->o_atime;

> - if ( compare & OBD_MD_FLMTIME )
> + if (compare & OBD_MD_FLMTIME)
> res = (res || (dst->o_mtime != src->o_mtime));

etc...




\
 
 \ /
  Last update: 2014-09-09 01:01    [W:0.024 / U:1.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site