Messages in this thread | | | Subject | Re: [PATCH] drivers: staging: lustre: Fix "space prohibited after that open parenthesis '('" errors | From | Joe Perches <> | Date | Mon, 08 Sep 2014 15:38:01 -0700 |
| |
On Mon, 2014-09-08 at 17:32 -0500, Greg Donald wrote: > Fix checkpatch.pl "space prohibited after that open parenthesis '('" errors [] > diff --git a/drivers/staging/lustre/lustre/obdclass/obdo.c b/drivers/staging/lustre/lustre/obdclass/obdo.c [] > @@ -161,35 +161,35 @@ int obdo_cmp_md(struct obdo *dst, struct obdo *src, u32 compare) > { > int res = 0; > > - if ( compare & OBD_MD_FLATIME ) > + if (compare & OBD_MD_FLATIME) > res = (res || (dst->o_atime != src->o_atime));
These would be nicer as
res |= dst->o_atime != src->o_atime;
> - if ( compare & OBD_MD_FLMTIME ) > + if (compare & OBD_MD_FLMTIME) > res = (res || (dst->o_mtime != src->o_mtime));
etc...
| |